feat: better code generation for let:
directives in SSR mode
#12611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while working on #12596 and didn't want it to get lost. There's no need to mess around with
$$slotProps
, we can just use a destructured parameter. This removes the only place where we're usingstate.getters
in SSR mode, which means we can make that a client-side-only mechanism.Stuff I'd like to fix while I'm at it:
<slot>
propsthe AST is wrong —actually it would be annoying to fix, and we'd have to undo the fix for the legacy AST. we're going to get rid of it one day anyway so let's just leave itlet:foo={{ bar: baz }}
should create anObjectPattern
for{ bar: baz }
, not anObjectExpression
. Minor point but should be easy to fixBefore submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint