Skip to content

feat: better code generation for let: directives in SSR mode #12611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jul 25, 2024

Found this while working on #12596 and didn't want it to get lost. There's no need to mess around with $$slotProps, we can just use a destructured parameter. This removes the only place where we're using state.getters in SSR mode, which means we can make that a client-side-only mechanism.

Stuff I'd like to fix while I'm at it:

  • there's no need to use getters for <slot> props
  • the AST is wrong — let:foo={{ bar: baz }} should create an ObjectPattern for { bar: baz }, not an ObjectExpression. Minor point but should be easy to fix actually it would be annoying to fix, and we'd have to undo the fix for the legacy AST. we're going to get rid of it one day anyway so let's just leave it

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: eb4c203

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit c66d2cf into main Jul 25, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the better-server-lets branch July 25, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants